Drop unused locations upfront #207
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
add-template-refactor-back-plus-patches
to
dev
December 2, 2021 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain forecasters, like
Imperial-ensemble2, only predict for select locations. This interferes with some of our as-of data selection logic and creates in the final score data an "NA" forecaster with "NA" ahead (hence the second facet of the plot) that causes plot shenanigans. Prevent by removing invalid locations (e.g. "US" if "AK" is selected) during initial filtering of score data, before as-of data is created and joined on.Closes #160. Also interacts with #161.